Rename and enhance NetworkHelper methods #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed method name from `GetAllLocalIPv4` to `GetAllLocalIPv4ByNIC` in `NetworkHelper.cs` while keeping the default parameter. - Added a new method `GetAllLocalIPv4` to retrieve local IPv4 addresses of the current machine. - Updated `MainViewModel.cs` to convert the result of `GetAllLocalIPv4` to a list for improved IP address handling.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
TouchSenderTablet.GUI/ViewModels/MainViewModel.cs:116
- Consider using the candidateIpAddresses variable consistently instead of recalling NetworkHelper.GetAllLocalIPv4(), to ensure uniformity and prevent discrepancies in the displayed data.
IpAddresses = candidateIpAddresses.Count > 0 ? string.Join(" / ", NetworkHelper.GetAllLocalIPv4()) : "Unknown".GetLocalized();
TouchSenderReceiver/Helpers/NetworkHelper.cs:17
- The list initialization syntax '[]' is not valid in C#. Replace it with 'new List();'.
List<string> ipAddrList = [];
- Changed the assignment of `IpAddresses` to use the pre-fetched `candidateIpAddresses` list instead of calling `NetworkHelper.GetAllLocalIPv4()` twice. - Improved code efficiency by avoiding redundant method calls.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
TouchSenderReceiver/Helpers/NetworkHelper.cs:17
- The list initialization syntax is incorrect; replace [] with new List() to properly instantiate the list.
List<string> ipAddrList = [];
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new?
GetAllLocalIPv4toGetAllLocalIPv4ByNICinNetworkHelper.cswhile keeping the default parameter.GetAllLocalIPv4to retrieve local IPv4 addresses of the current machine.MainViewModel.csto convert the result ofGetAllLocalIPv4to a list for improved IP address handling.