Feat/bms #39
Draft
Feat/bms #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forrisdahl
requested changes
Nov 5, 2025
forrisdahl
requested changes
Nov 9, 2025
Comment on lines
22
to
30
| void BQ76942_Init(void) | ||
| { | ||
| // init SPI | ||
| SERCOM0_SPI_Initialize(); | ||
|
|
||
| // configure CS pin as output and set HIGH (inactive) | ||
| PORT_REGS->GROUP[BQ_CS_GROUP].PORT_DIRSET = BQ_CS_MASK; | ||
| PORT_REGS->GROUP[BQ_CS_GROUP].PORT_OUTSET = BQ_CS_MASK; | ||
| } |
Contributor
There was a problem hiding this comment.
SERCOM0 initialize should already be called by the Sys_Initialize function.
I think this function should be used to initialize the IC to use the correct settings.
Comment on lines
50
to
87
| bool WriteReg(uint8_t regAddr, uint8_t value) | ||
| { | ||
| /* First byte: MSB=1 to indicate WRITE, lower 7 bits = register address */ | ||
| uint8_t tx[2]; | ||
| tx[0] = (uint8_t)(0x80 | (regAddr & 0x7F)); /* W flag + address */ | ||
| tx[1] = value; | ||
|
|
||
| if (SERCOM0_SPI_IsBusy()) | ||
| return false; | ||
|
|
||
| BQ_CS_Low(); | ||
| bool ok = SERCOM0_SPI_Write(tx, 2U); | ||
| BQ_CS_High(); | ||
|
|
||
|
|
||
|
|
||
| return ok; | ||
| } | ||
|
|
||
|
|
||
| bool ReadReg(uint8_t regAddr, uint8_t *value) | ||
| { | ||
| uint8_t tx[2] = { (regAddr & 0x7F), 0x00 }; | ||
| uint8_t rx[2] = { 0, 0 }; | ||
|
|
||
| if (SERCOM0_SPI_IsBusy()) | ||
| return false; | ||
|
|
||
| BQ_CS_Low(); | ||
| bool ok = SERCOM0_SPI_WriteRead(tx, 2U, rx, 2U); | ||
| BQ_CS_High(); | ||
|
|
||
| if (ok) | ||
| *value = rx[1]; | ||
|
|
||
|
|
||
| return ok; | ||
| } |
Contributor
There was a problem hiding this comment.
Are all registers 1 byte? I think it would make sense to have the length as an input so you could configure multiple registers in the same function call instead of hard coding the length like this
Also the convention for functions in C are snake case.
Comment on lines
152
to
155
| if (!WriteReg(0x3E, lsb)) | ||
| return false; | ||
| if (!WriteReg(0x3F, msb)) | ||
| return false; |
Contributor
There was a problem hiding this comment.
See the earlier comments, instead of having multiple functions calls and SPI transmission this could be done in one transmission.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.