Update to use boost::beast (websocket transition). Needs testing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Force pushed missing files and a rebase so that merge conflicts were resolved. |
Owner
Author
|
Force pushed a rebase with some tweaks to the design to make it more robust. |
vtnerd
force-pushed
the
update/beast
branch
5 times, most recently
from
72eeeb8 to
5364569
Compare
Owner
Author
|
Force pushed a change to Asia handling - the previous version had potential memory leaks. |
vtnerd
force-pushed
the
update/beast
branch
8 times, most recently
from
a536921 to
c139377
Compare
Owner
Author
|
Force pushed new unit tests for the boost::beast based http client. This caught two bugs, so it was worth the effort. The ci has also been updated to run sanitizers against the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes in the #3 lookahead PR.
This transitions the http client to
boost::beastsuch that the REST calls run asynchronously in aboost::asioevent loop. The objective is to introduce a "push" (websocket) interface from the server, such that polling is no longer needed on the frontend. This should reduce server overload, but add some complexity on both ends. The code will automatically fall back onto a polling scheme if the server doesn't support the new websocket mode.I'm leaving this as draft until the lookahead patch gets finalized; fcmp++ spending is a higher priority.