Adaptation to ecoinvent 3.9.1 + Atmospheric aerosol loading#3
Adaptation to ecoinvent 3.9.1 + Atmospheric aerosol loading#3gpuigsamper wants to merge 11 commits intovtulus:devfrom
Conversation
- Carbon dioxide, from soil or biomass stock (air indoor) - Methane (air urban air close to ground) - Methane, from soil or biomass stock (air indoor) Modified NMVOC elementary flows to the terminology in ecoinvent 3.9.1
- Carbon dioxide, from soil or biomass stock, categories: air::indoor - Methane, categories: air::urban air close to ground Modified terminology for NMVOC elementary flows to match ecoinvent 3.9.1
…9.1 and modified the name of NMVOC elementary flows
…HG component of biosphere integrity)
|
@gpuigsamper would we want to enable backwards compatibility? This could be straightforward to implement: leave the old elementary flows, and each version of ecoinvent would pick the ones that it needs. Is that so? (My thinking is a little bit rusty) 😅 |
|
Hi @vtulus ! Yes, that would be exactly the idea. |
|
I think it is better if the methods are compatible with any ecoinvent version, so the user does not have to think which method to install when. Do you think that's possible? |
|
That would be ideal @vtulus , so users do not have to worry about versions! However, with the current implementation this is not be possible since it raises an error of unlinked exchanges. We will need to modify the add_aesa_pbs function. AESAmethods/src/aesa_pbs/aesa_pbs.py Line 20 in 704511a |
|
💯 yes, you're right! Do you see any solution for that? |
|
Yes ! Fast solution is to drop unlinked characterization factors before writing the LCIA method. Ideally printing the unlinked CFs, so users are aware. This works well for me. Would it be necessary to check if CFs to be drop are among those that change between ecoinvent versions? We could incorporate that by keeping track of eliminated or modified elementary flows before droping the CFs. |
|
We basically depend on the default |
|
There are some changes in the LCIA methods are installed with the |
…round water compartement. This is made in line with the original PB-LCIA method (Ryberg et al., 2018). The CFs are applied to N-compunds (NO3- and N-tot) to freshwater as suggested by Ryberg et al.(2018) because it is the most dominant route for N loss from agricultural processes.
|
Regarding the mapping of elementary flows across different |
A new release could be done on the basis of these changes (tag, v0.9.1).
TODO: