Skip to content

Add support for _TZE204_81yrt3lo Power Meter#22

Draft
Konnichy wants to merge 45 commits intow35l3y:betafrom
Konnichy:beta
Draft

Add support for _TZE204_81yrt3lo Power Meter#22
Konnichy wants to merge 45 commits intow35l3y:betafrom
Konnichy:beta

Conversation

@Konnichy
Copy link

Hello,

Here is a pull request that adds direct detection and support for this power meter:
https://fr.aliexpress.com/item/1005006200619110.html

Please ignore changes in /README.md (I didn't have the required env vars set). Also, I notice /personal-tuya-devices/README.md was not updated for some reason. But I guess these files will be updated on your side anyways, right?

Thanks,
Yann

@w35l3y
Copy link
Owner

w35l3y commented Dec 30, 2024

Definitions in the model must match profile.

For example, group: 1 means that the expected component is main. group: 2 means the expected component is main02

I can't accept reworks in the profile like you did because it would affect every user with similar devices.
You can use it in your own channel.

@Konnichy
Copy link
Author

Hello @w35l3y ,

Thanks for your feedback.
I'm sorry, I originally meant this pull request to add the simplest compatibility. I wanted to make one clamp functional with device _TZE204_81yrt3lo, then submit a separate pull request to add the second clamp. I didn't know pushing in my own repository would dynamically update this pull request. So this is still a work-in-progress.

I can't accept reworks in the profile like you did because it would affect every user with similar devices. You can use it in your own channel.

I may end up keeping fine-grained customization in my channel, but I still would like to contribute here.

I agree my enhancements to the profile would break other devices. Since I also notice there is only one other device using this profile, I thought about updating it too. But it would still need some reconfiguration on the side of current users, if any.
Since _TZE204_81yrt3lo provides more information than what the original profile supports, would it be acceptable if I added capabilities to support more datapoints, but with no additional component or preference renaming?

@w35l3y
Copy link
Owner

w35l3y commented Jan 17, 2025

would it be acceptable if I added capabilities to support more datapoints, but with no additional component or preference renaming?

You may add capabilities, but without additional components/preferences, it wouldn't be functional, only for documentation porpuse.

there is only one other device using this profile

The driver also works in "similarity mode" that allows user to choose this profile without automatic detection.

@Konnichy Konnichy marked this pull request as draft February 17, 2025 19:39
@Konnichy
Copy link
Author

Konnichy commented Feb 19, 2025

Hello @w35l3y,

There are 3 components in the your multi-phase profile: main, main02, main03. Apparently used for phases A, B, C of 3-phase devices.

Device _TZE204_81yrt3lo only measures 2 phases, A and B, but also provides a datapoint for the sum of A+B energies. Which option would you prefer:

  1. Using "main" for A+B, "main02" for phase A, "main03" for phase B?
  2. Or "main" for phase A, "main02" for phase B, leave alone "main03" because there is no 3rd phase, but then also ignore the datapoint of A+B energies?
  3. Or "main" for phase A, "main02" for phase B, and use "main03" for A+B?

It looks like your profile's labeling would better suit option 2, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants