Update: Clarify and update role allowances for td and th elements #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR covers a few things: 1. clarifies that the mention of "ancestor table" was meant to mean "nearest ancestor table" - re: validator/validator#1304 2. Per feedback / use cases for correcting errant tables, the allowances for td and th elements have been expanded to allow other reasonable roles that developers may need to use.
| </p> | ||
| <div class="note"> | ||
| <p> | ||
| If a `td` element's nearest descendant `table` element is exposed with a role of `table`, `grid` or `treegrid`, |
Member
There was a problem hiding this comment.
would this (and the matching one below) benefit from a tiny preamble, like "If a td element has a nested table, and the descendant table element..."
| </p> | ||
| <div class="note"> | ||
| <p> | ||
| If a `tr` element's nearest descendant `table` element is exposed with a role of `table`, `grid` or `treegrid`, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers a few things:
TODO: need test cases / updated test cases for the updated role allowances.
Preview | Diff