Allow payment handlers to report back errors via Payment Request API #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbjacobs
approved these changes
Nov 24, 2025
stephenmcgruer
force-pushed
the
smcgruer-add-payment-handler-error-case
branch
from
ccb85c9 to
aaa261e
Compare
stephenmcgruer
commented
Jan 30, 2026
Collaborator
Author
stephenmcgruer
left a comment
stephenmcgruer
left a comment
There was a problem hiding this comment.
Ok I've incorporated your comments (thanks!) and put together three variants:
- A version where we take the unspecified error from the platform handler, and use the "let |error| be an appropriate {{DOMException}}" wording -e9eec11
- A version where the payment handler is presumed to pass us a DOMException directly (i.e., any conversion to DOMException happens 'inside' the relevant payment handler and any spec it has) - ae1280b
- A version which uses a general JavaScript value like AbortSignal does, and rejects with that reason - d976730
I personally prefer (2), but I'm open to any of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1040
The following tasks have been completed:
Implementation commitment:
Optional, impact on Payment Handler spec? <-- TBD!
Preview | Diff