Add test_on and test_onload convenience functions.#108
Add test_on and test_onload convenience functions.#108
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/4091 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Isn't the order of arguments a little..odd? It's closely related to addEventListener which has event type, function - and here we suddenly reverse it to function, object, type ..? I would find easier to remember by association. |
|
So the reasoning is that it matches all the other test* functions that always take the test function as their first argument (did that sentence make sense). I agree it feels a bit odd in this case though. |
This change is