This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Clean the test names of instances' properties' checks#170
Open
nox wants to merge 3 commits intow3c:masterfrom
Open
Clean the test names of instances' properties' checks#170nox wants to merge 3 commits intow3c:masterfrom
nox wants to merge 3 commits intow3c:masterfrom
Conversation
Static operations aren't supposed to appear on platform interface instances, so there are no reason to have a "Foo interface: bar() must inherit property Qux" for them.
They might be overloaded and thus we should test them only once, instead of including the member's index in the test name to avoid dupes.
|
Critic review: https://critic.hoppipolla.co.uk/r/6068 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Member
|
r? @Ms2ger |
Member
|
Waiting on review. @Ms2ger? |
Contributor
|
Ugh. I recall I wanted to rewrite idlharness a bit to make this simpler, but I don't recall how exactly. I'll try to figure out if I wrote any code for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the third commit for what this fixes.
This change is