This repository was archived by the owner on Sep 19, 2018. It is now read-only.
Issue #177: Update assert_readonly implementation to use ES5 features#178
Open
DLehenbauer wants to merge 2 commits intow3c:masterfrom
MicrosoftEdge:fix-assert-readonly
Open
Issue #177: Update assert_readonly implementation to use ES5 features#178DLehenbauer wants to merge 2 commits intow3c:masterfrom MicrosoftEdge:fix-assert-readonly
DLehenbauer wants to merge 2 commits intow3c:masterfrom
MicrosoftEdge:fix-assert-readonly
Conversation
|
Critic review: https://critic.hoppipolla.co.uk/r/6136 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Member
|
Because mentions in the title aren't cross-referenced (thanks GitHub!): #177. |
zqzhang
pushed a commit
to zqzhang/realsense-extensions-crosswalk
that referenced
this pull request
Apr 11, 2016
Apply changes from w3c/testharness.js#178 with trailing spaces removed. This shall fixes https://crosswalk-project.org/jira/browse/XWALK-6645
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Determines if the property is readonly by inspecting it's descriptor and verifying that attempts to set throw under strict mode.
This change is