Update extensions and skins to their latest minor versions#274
Open
Update extensions and skins to their latest minor versions#274
Conversation
vedmaka
reviewed
Jul 25, 2025
| path = _resources/extensions/SubpageWatchlist | ||
| url = https://gerrit.wikimedia.org/r/mediawiki/extensions/SubpageWatchlist.git | ||
| branch = REL1_35 | ||
| branch = REL1_39 |
Contributor
There was a problem hiding this comment.
I think we should remove the branch completely, as the only scenario where this takes effect is when the --remote flag is supplied to the git submodule update command. The default behavior for submodules is to checkout the commit that's fixed by the parent repo, and that's how we use submodules, thus the branch property is ignored https://git-scm.com/docs/gitmodules#Documentation/gitmodules.txt-submodulenamebranch
vedmaka
requested changes
Dec 8, 2025
| @@ -1,5 +1,6 @@ | |||
| # Mandatory | |||
| MYSQL_ROOT_PASSWORD= | |||
| MW_ADMIN_PASS= | |||
Contributor
There was a problem hiding this comment.
MW_ADMIN_PASS is only mandatory for fresh installs, but is optional for existing database. Let's keep it in the Optional section with that note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.