Factorized log probability method, general variational bound class#10
Open
suhasshrinivasan wants to merge 15 commits intowalkerlab:mainfrom
Open
Factorized log probability method, general variational bound class#10suhasshrinivasan wants to merge 15 commits intowalkerlab:mainfrom
suhasshrinivasan wants to merge 15 commits intowalkerlab:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
Author
suhasshrinivasan
left a comment
There was a problem hiding this comment.
I decided to rollback ELU implementation, since changing its constructor broke backwards compatibility. We would need to discuss the modification once again.
Collaborator
Author
|
In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want the log probabilities of a random variable dimension by dimension when the distribution is factorized for a few cases such as density inspection. This PR adds factorized log probability computation methods in the core classes such as IndependentTrainableDistributionAdapter and also extends the idea to factorized log dets in transforms in normalizing flows and factorized elbo and iw bound in variational dequantized distributions. The functionality is lightly tested and elucidated in a jupyter notebook in
notebooks/factorized_log_prob.ipynb.