-
Notifications
You must be signed in to change notification settings - Fork 9
Feat/chart callbacks #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
handgull
wants to merge
18
commits into
warioddly:dev
Choose a base branch
from
handgull:feat/chart-callbacks
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+437
−171
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4f1137d
Merge pull request #36 from warioddly/dev
warioddly ca35f96
refactor: update plugin paths and improve Graphify interface structure
warioddly 41b680f
Merge pull request #37 from warioddly/feature/improve-graphify-interface
warioddly 2f74c7c
bump version to 1.3.0 in pubspec.yaml
warioddly a0d35a0
bump version to 1.2.0 in pubspec.yaml and pubspec.lock
warioddly 169a859
Merge pull request #38 from warioddly/feature/bump-version
warioddly 24ff7de
chore: update CHANGELOG.md for version 1.2.0 release
warioddly 02549da
Merge remote-tracking branch 'origin/main'
warioddly 0e77db5
refactor: update conditional imports to use dart.library.js_interop
warioddly 4a98d98
Merge pull request #41 from warioddly/40-when-running-with---wasm-it-…
warioddly b819eea
bump version to 1.2.1 in pubspec.yaml
warioddly 7629314
feat: remove linux platform support
warioddly e34face
new click feature testing setup + gradle bump
handgull 6f4c6bb
chart data sent when tapped
handgull 5421b50
added web implementation
handgull cb62649
some review fixes
handgull 1b10de3
removed print
handgull 9b9db1e
remove print
handgull File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| buildscript { | ||
| ext.kotlin_version = '1.8.10' | ||
| ext.kotlin_version = '2.1.0' | ||
| repositories { | ||
| google() | ||
| mavenCentral() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| import 'dart:developer'; | ||
|
|
||
| import 'package:flutter/material.dart'; | ||
| import 'package:graphify/graphify.dart'; | ||
|
|
||
| class ChartClick extends StatefulWidget { | ||
| const ChartClick({super.key}); | ||
|
|
||
| @override | ||
| State<ChartClick> createState() => _ChartClickState(); | ||
| } | ||
|
|
||
| class _ChartClickState extends State<ChartClick> { | ||
| late final GraphifyController _controller; | ||
| String _status = 'Ready to test clicks'; | ||
|
|
||
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| _controller = GraphifyController(); | ||
| _controller.chartClickedEvent.listen((data) { | ||
| debugPrint('listener received: $data'); | ||
| setState(() { | ||
| _status = 'Click received: ${data['name'] ?? 'Unknown'}'; | ||
| }); | ||
|
|
||
| log('TEST: Chart click received: $data'); | ||
| }); | ||
| } | ||
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| return Column( | ||
| children: [ | ||
| Expanded( | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(16), | ||
| child: Text( | ||
| _status, | ||
| style: const TextStyle(fontWeight: FontWeight.bold), | ||
| textAlign: TextAlign.center, | ||
| ), | ||
| ), | ||
| ), | ||
| Container( | ||
| height: 400, | ||
| margin: const EdgeInsets.all(8), | ||
| decoration: BoxDecoration( | ||
| border: Border.all(color: Colors.grey), | ||
| borderRadius: BorderRadius.circular(8), | ||
| ), | ||
| child: GraphifyView( | ||
| controller: _controller, | ||
| onConsoleMessage: (msg) { | ||
| debugPrint('WebView console: ${(msg as dynamic).message}'); | ||
|
Comment on lines
+54
to
+55
|
||
| }, | ||
| initialOptions: const { | ||
| "tooltip": { | ||
| "trigger": "axis", | ||
| "axisPointer": {"type": "shadow"} | ||
| }, | ||
| "legend": { | ||
| "data": ["Sales", "Marketing"] | ||
| }, | ||
| "xAxis": { | ||
| "type": "category", | ||
| "data": ["Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun"] | ||
| }, | ||
| "yAxis": {"type": "value"}, | ||
| "series": [ | ||
| { | ||
| "name": "Sales", | ||
| "type": "bar", | ||
| "data": [120, 200, 150, 80, 70, 110, 130], | ||
| "itemStyle": {"color": "#5470c6"} | ||
| }, | ||
| { | ||
| "name": "Marketing", | ||
| "type": "bar", | ||
| "data": [60, 100, 75, 40, 35, 55, 65], | ||
| "itemStyle": {"color": "#91cc75"} | ||
| } | ||
| ] | ||
| }, | ||
| ), | ||
| ), | ||
| ], | ||
| ); | ||
| } | ||
|
|
||
| @override | ||
| void dispose() { | ||
| _controller.dispose(); | ||
| super.dispose(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -1,15 +1,17 @@ | ||||||||
| import 'package:graphify/src/controller/interface.dart' as controller_interface; | ||||||||
|
|
||||||||
| class GraphifyController extends controller_interface.GraphifyController { | ||||||||
|
|
||||||||
| @override | ||||||||
| void update(Map<String, dynamic>? options) { | ||||||||
| throw UnimplementedError("update() is not implemented"); | ||||||||
| } | ||||||||
|
|
||||||||
| @override | ||||||||
| Stream<Map<String, dynamic>> get chartClickedEvent => | ||||||||
| throw UnimplementedError("chartClickedEvent is not implemented"); | ||||||||
|
Comment on lines
+10
to
+11
|
||||||||
| Stream<Map<String, dynamic>> get chartClickedEvent => | |
| throw UnimplementedError("chartClickedEvent is not implemented"); | |
| Stream<Map<String, dynamic>> get chartClickedEvent => Stream.empty(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version in CHANGELOG.md is documented as 1.2.0, but pubspec.yaml shows 1.2.1. These versions should be consistent across all documentation.