Added a comand for checking if user email exist in api and MW user tables #1031
+156
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
Jan 8, 2026
Contributor
tarrow
left a comment
tarrow
left a comment
There was a problem hiding this comment.
Looks like a good direction to start in. Definitely a bit different from the raw string matching in the ticket but seems a fine idea to me. I like the test. I guess you're also working on one for Wiki data too?
One comment I added for myself to worry about because I have some vague memory about these connections being a bit odd when we set them like this but I need to do some research
|
|
||
| $manager = app()->db; | ||
| $manager->purge('mw'); | ||
| $mwConn = $manager->connection('mw'); |
Contributor
There was a problem hiding this comment.
For Tom to look up:
- do we also need to undo this?
dati18
reviewed
Jan 8, 2026
| $mwConn = $manager->connection('mw'); | ||
| $pdo = $mwConn->getPdo(); | ||
|
|
||
| $dbStmt = $pdo->query("SHOW DATABASES LIKE 'mwdb_%'"); |
Contributor
There was a problem hiding this comment.
wrapping this in a try-catch to log any errors that may happen?
Contributor
Author
There was a problem hiding this comment.
I am not sure a try catch is necessary here. I think it is fine as we get the thrown exception on the console anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T410856