Fixed issue #344 #352
Open
Fixed issue #344 #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue>>upload photo TBanner was opening a new tab
razbakov
requested changes
Mar 16, 2023
| <a | ||
| v-if="link" | ||
| :href="link" | ||
| target="_blank" |
Contributor
There was a problem hiding this comment.
This will break the social media buttons. They suppose to open new window.
| mobile="Upload your photo" | ||
| action="Upload" | ||
| link="https://wedance.vip/settings?tab=profile" | ||
| to="/settings" |
Contributor
There was a problem hiding this comment.
It suppose to open profile tab in settings
Contributor
|
Pull request description should include the issue number, provide link and instructions how to test it |
Contributor
|
No need to describe what you did, need to describe why. Please read about commit and pull request best practices |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NuxtLink to TBanner as a v-else-if prop "to" is passed. Similar to what is done in TButton