Conversation
jrryjcksn
left a comment
jrryjcksn
left a comment
There was a problem hiding this comment.
The update to multimaster_test looks good; I think we need to change the controller manifest, though...
| containers: | ||
| - name: controller | ||
| image: weaveworks/cluster-api-existinginfra-controller:v0.2.4 | ||
| image: weaveworks/cluster-api-existinginfra-controller:latest |
There was a problem hiding this comment.
I don't think it's safe to use latest here. That would mean that any wk binary someone used after CAPEI got updated would end up pulling the new manifest (which could easily be inconsistent w/ the binary in some way) 🤔
There was a problem hiding this comment.
@jrryjcksn You're right. I'll revert this.
| } | ||
| // FIXME: look this value up more dynamically. | ||
| const capeiImage = "weaveworks/cluster-api-existinginfra-controller:v0.2.4" | ||
| release, err := getLatestCAPEIRelease() |
There was a problem hiding this comment.
Here, though, it seems great! :-)
There was a problem hiding this comment.
I think we want the version that matches the go.mod file - otherwise there is the potential to create the seed node with one version and the remaining nodes with a different version.
There was a problem hiding this comment.
That seems interesting. I'm curious in how that could happen. Would getLatestCAPEIRelease() be called many times? It seems just to be called once. 🙂
3 participants
No description provided.