Skip to content

Returning the promise in promise_test#5228

Closed
youennf wants to merge 1 commit intoweb-platform-tests:masterfrom
youennf:fixing-cors-preflight-status
Closed

Returning the promise in promise_test#5228
youennf wants to merge 1 commit intoweb-platform-tests:masterfrom
youennf:fixing-cors-preflight-status

Conversation

@youennf
Copy link
Contributor

@youennf youennf commented Mar 27, 2017

No description provided.

@wpt-pr-bot
Copy link
Collaborator

wpt-pr-bot commented Mar 27, 2017

Notifying @annevk, @jdm, and @mnot. (Learn how reviewing works.)

@annevk
Copy link
Member

annevk commented Mar 27, 2017

Hmm, this ends up breaking #5129 even more, but does seem like a good idea to fix... Any ETA on review for that PR?

@ghost
Copy link

ghost commented Mar 27, 2017

View the complete job log.

Firefox (nightly channel)

Testing web-platform-tests at revision 1346b97
Using browser at version BuildID 20170326110231; SourceStamp f5e214144799889e2408c4841351f4053f00544e
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-preflight-status-worker.html
Subtest Results Messages
OK
Preflight answered with status 200 PASS {}
Preflight answered with status 201 PASS {}
Preflight answered with status 202 PASS {}
Preflight answered with status 203 PASS {}
Preflight answered with status 204 PASS {}
Preflight answered with status 205 PASS {}
Preflight answered with status 206 PASS {}
Preflight answered with status 300 PASS {}
Preflight answered with status 301 PASS {}
Preflight answered with status 302 PASS {}
Preflight answered with status 303 PASS {}
Preflight answered with status 304 PASS {}
Preflight answered with status 305 PASS {}
Preflight answered with status 306 PASS {}
Preflight answered with status 307 PASS {}
Preflight answered with status 308 PASS {}
Preflight answered with status 400 PASS {}
Preflight answered with status 401 PASS {}
Preflight answered with status 402 PASS {}
Preflight answered with status 403 PASS {}
Preflight answered with status 404 PASS {}
Preflight answered with status 405 PASS {}
Preflight answered with status 501 PASS {}
Preflight answered with status 502 PASS {}
Preflight answered with status 503 PASS {}
Preflight answered with status 504 PASS {}
Preflight answered with status 505 PASS {}
/fetch/api/cors/cors-preflight-status.html
Subtest Results Messages
OK
Preflight answered with status 200 PASS
Preflight answered with status 201 PASS
Preflight answered with status 202 PASS
Preflight answered with status 203 PASS
Preflight answered with status 204 PASS
Preflight answered with status 205 PASS
Preflight answered with status 206 PASS
Preflight answered with status 300 PASS
Preflight answered with status 301 PASS
Preflight answered with status 302 PASS
Preflight answered with status 303 PASS
Preflight answered with status 304 PASS
Preflight answered with status 305 PASS
Preflight answered with status 306 PASS
Preflight answered with status 307 PASS
Preflight answered with status 308 PASS
Preflight answered with status 400 PASS
Preflight answered with status 401 PASS
Preflight answered with status 402 PASS
Preflight answered with status 403 PASS
Preflight answered with status 404 PASS
Preflight answered with status 405 PASS
Preflight answered with status 501 PASS
Preflight answered with status 502 PASS
Preflight answered with status 503 PASS
Preflight answered with status 504 PASS
Preflight answered with status 505 PASS

@ghost
Copy link

ghost commented Mar 27, 2017

View the complete job log.

Chrome (unstable channel)

Testing web-platform-tests at revision 1346b97
Using browser at version 59.0.3047.0 dev
Starting 10 test iterations
All results were stable

All results

2 tests ran
/fetch/api/cors/cors-preflight-status-worker.html
Subtest Results Messages
OK
Preflight answered with status 200 PASS {}
Preflight answered with status 201 PASS {}
Preflight answered with status 202 PASS {}
Preflight answered with status 203 PASS {}
Preflight answered with status 204 PASS {}
Preflight answered with status 205 PASS {}
Preflight answered with status 206 PASS {}
Preflight answered with status 300 PASS {}
Preflight answered with status 301 PASS {}
Preflight answered with status 302 PASS {}
Preflight answered with status 303 PASS {}
Preflight answered with status 304 PASS {}
Preflight answered with status 305 PASS {}
Preflight answered with status 306 PASS {}
Preflight answered with status 307 PASS {}
Preflight answered with status 308 PASS {}
Preflight answered with status 400 PASS {}
Preflight answered with status 401 PASS {}
Preflight answered with status 402 PASS {}
Preflight answered with status 403 PASS {}
Preflight answered with status 404 PASS {}
Preflight answered with status 405 PASS {}
Preflight answered with status 501 PASS {}
Preflight answered with status 502 PASS {}
Preflight answered with status 503 PASS {}
Preflight answered with status 504 PASS {}
Preflight answered with status 505 PASS {}
/fetch/api/cors/cors-preflight-status.html
Subtest Results Messages
OK
Preflight answered with status 200 PASS
Preflight answered with status 201 PASS
Preflight answered with status 202 PASS
Preflight answered with status 203 PASS
Preflight answered with status 204 PASS
Preflight answered with status 205 PASS
Preflight answered with status 206 PASS
Preflight answered with status 300 PASS
Preflight answered with status 301 PASS
Preflight answered with status 302 PASS
Preflight answered with status 303 PASS
Preflight answered with status 304 PASS
Preflight answered with status 305 PASS
Preflight answered with status 306 PASS
Preflight answered with status 307 PASS
Preflight answered with status 308 PASS
Preflight answered with status 400 PASS
Preflight answered with status 401 PASS
Preflight answered with status 402 PASS
Preflight answered with status 403 PASS
Preflight answered with status 404 PASS
Preflight answered with status 405 PASS
Preflight answered with status 501 PASS
Preflight answered with status 502 PASS
Preflight answered with status 503 PASS
Preflight answered with status 504 PASS
Preflight answered with status 505 PASS

@youennf
Copy link
Contributor Author

youennf commented Mar 27, 2017

@annevk, you can merge it in #5129 if that is more convenient.

@jugglinmike jugglinmike mentioned this pull request Mar 27, 2017
Open
annevk added a commit that referenced this pull request Mar 27, 2017
@annevk
Fetch: add return statement to cors-preflight-status.any.js
c2899e4 
Supersedes #5228.
@annevk annevk mentioned this pull request Mar 27, 2017
Merged
@annevk
Copy link
Member

annevk commented Mar 27, 2017

Created #5230 to take care of this.

@annevk annevk closed this Mar 27, 2017
jdm pushed a commit that referenced this pull request Mar 27, 2017
@annevk @jdm
Fetch: add return statement to cors-preflight-status.any.js (#5230)
2c544f0 
Supersedes #5228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

fetch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@youennf @wpt-pr-bot @annevk