Open
Conversation
Author
|
After taking a break the obvious come to my mind and knew how to create this badgeProps and felt stupid about asking :D I have updated the badgeStyle to badgeProps without including children as you already do it with the badge prop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I have added a badgeStyle props as commented in the issue #67
I wanted to include all the badgeProps in this props as in the example :
badgeProps={mybadgeProps}but i dont know what kind of interface type i should use :
I dont know much Typescript so if you want me to add more props and not just the style i can do a new PR later but i would appreciate if you can indicate me the type of the props i should put.
Meanwhile i hope this PR will be useful and thank you for this nice library ;)