Skip to content

[bug] at is ignored #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lmartelli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[bug] at is ignored #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/test/java/uk/org/webcompere/modelassert/json/ExamplesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,4 +541,14 @@ void atPath_whenKeysAreMissingInTheActualThenObjectContainsFixesIt() {
.path("z").objectContains()
.isEqualTo("{z:{b:{d:false, c:true}}}");
}

@Test
void at_isCheckedEvenIfTreeComparisonSucceeds() {
assertThatThrownBy(() ->
assertJson("{foo: 42}")
.where().objectContains()
.at("/foo").isText()
.isEqualTo("{}"))
.isInstanceOf(AssertionFailedError.class);
Copy link
Member

@ashleyfrieze ashleyfrieze Nov 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can explain this one. It's sort of user-error, but it's sort of not.

When we use objectContains we're essentially relaxing the rules. We're telling the asserter to ignore any field not present in the expected.

The following version of your test does what your assertion is trying to do:

assertThatThrownBy(() ->
        assertJson("{foo: 42}")
                .where().objectContains()
                .at("/foo").isText()
                .isEqualTo("{foo:42}"))
        .isInstanceOf(AssertionFailedError.class);

}
}