Skip to content

feat(jwt): get/refresh JWT and register data channel with JWT#4680

Open
Tianhui-Han wants to merge 21 commits intowebex:nextfrom
Tianhui-Han:feat/jwt_get/refresh-token-and-register-data-channel
Open

feat(jwt): get/refresh JWT and register data channel with JWT#4680
Tianhui-Han wants to merge 21 commits intowebex:nextfrom
Tianhui-Han:feat/jwt_get/refresh-token-and-register-data-channel

Conversation

@Tianhui-Han
Copy link
Contributor

This pull request addresses

refer story https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-685070

by making the following changes

  • Updated some APIs to add the dataChannelToken parameter
  • Add methods to get/refresh the dataChannelToken and register the dataChannel
  • Implemented a DataChannelAuthTokenInterceptor with delayed retries and a max retry limit

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@Tianhui-Han Tianhui-Han force-pushed the feat/jwt_get/refresh-token-and-register-data-channel branch from 78c34a3 to ef26a86 Compare February 2, 2026 08:01
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4680.d3m3l2kee0btzx.amplifyapp.com

@Tianhui-Han Tianhui-Han marked this pull request as ready for review February 4, 2026 07:54
@Tianhui-Han Tianhui-Han requested review from a team as code owners February 4, 2026 07:54
@mickelr mickelr added the validated If the pull request is validated for automation. label Feb 5, 2026
@mickelr
Copy link
Contributor

mickelr commented Feb 5, 2026

Suggestions:

  1. We may need add a feature toggle
  2. We may need save the new token for the next call


const isPracticeSession = this.webinar.isJoinPracticeSessionDataChannel();
// @ts-ignore
const refreshedPracticeToken = this.webex.internal.llm.getDatachannelToken(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic here should be like:

const refreshedToken = this.webex.internal.llm.getDatachannelToken(isPracticeSession);

const  finalToken = refreshedToken ?? (isPracticeSession ? practiceSessionDatachannelToken : datachannelToken);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants