feat(jwt): get/refresh JWT and register data channel with JWT#4680
Open
Tianhui-Han wants to merge 21 commits intowebex:nextfrom
Open
feat(jwt): get/refresh JWT and register data channel with JWT#4680Tianhui-Han wants to merge 21 commits intowebex:nextfrom
Tianhui-Han wants to merge 21 commits intowebex:nextfrom
Conversation
78c34a3 to
ef26a86
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Contributor
|
Suggestions:
|
mickelr
reviewed
Feb 13, 2026
|
|
||
| const isPracticeSession = this.webinar.isJoinPracticeSessionDataChannel(); | ||
| // @ts-ignore | ||
| const refreshedPracticeToken = this.webex.internal.llm.getDatachannelToken(true); |
Contributor
There was a problem hiding this comment.
I think the logic here should be like:
const refreshedToken = this.webex.internal.llm.getDatachannelToken(isPracticeSession);
const finalToken = refreshedToken ?? (isPracticeSession ? practiceSessionDatachannelToken : datachannelToken);
mickelr
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses
refer story https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-685070
by making the following changes
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.