Conversation
Resolves the event loop conflict between pytest-asyncio and pytest-playwright by isolating the integration tests into a separate test suite. The integration tests, which rely on pytest-asyncio, are moved to a dedicated `tests/integration` directory with its own `pytest.ini` and `conftest.py`. This allows them to run in a separate environment with the necessary `asyncio_mode = auto` configuration. The root `pytest.ini` is updated to exclude the new directory, preventing the event loop conflict that was causing the test suite to fail.
Resolves the event loop conflict between pytest-asyncio and pytest-playwright by isolating the integration tests into a separate test suite. The integration tests, which rely on pytest-asyncio, are moved to a dedicated `tests/integration` directory with its own `pytest.ini` and `conftest.py`. This allows them to run in a separate environment with the necessary `asyncio_mode = auto` configuration. The root `pytest.ini` is updated to exclude the new directory, preventing the event loop conflict that was causing the test suite to fail.
Resolves the event loop conflict between pytest-asyncio and pytest-playwright by isolating the integration tests into a separate test suite. The integration tests, which rely on pytest-asyncio, are moved to a dedicated `tests/integration` directory with its own `pytest.ini` and `conftest.py`. This allows them to run in a separate environment with the necessary `asyncio_mode = auto` configuration. The root `pytest.ini` is updated to exclude the new directory, preventing the event loop conflict that was causing the test suite to fail. Also adds `nest-asyncio` to the CI workflow to ensure that the necessary dependencies are installed in the CI environment.
Adds the `playwright` and `pytest-playwright` dependencies to the CI workflow. These were missing, which caused the end-to-end tests to fail during collection with a `ModuleNotFoundError`.
Adds assertions to the end-to-end test to ensure the iframe element and its content frame are not `None` before use. This resolves a `mypy` error that was causing the CI to fail.
Adds a step to the CI workflow to install the Playwright browser binaries. This was the final missing piece, and the CI should now pass.
webmaven
deleted the
feature-restore-e2e-test-2096908966754869252-11579160641298013651
branch
webmaven
restored the
feature-restore-e2e-test-2096908966754869252-11579160641298013651
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the event loop conflict between pytest-asyncio and pytest-playwright by isolating the integration tests into a separate test suite.
The integration tests, which rely on pytest-asyncio, are moved to a dedicated
tests/integrationdirectory with its ownpytest.iniandconftest.py. This allows them to run in a separate environment with the necessaryasyncio_mode = autoconfiguration.The root
pytest.iniis updated to exclude the new directory, preventing the event loop conflict that was causing the test suite to fail.