Try to load the sha from tags if the branch can't be found#9
Open
BestFriendChris wants to merge 1 commit intowebsterclay:masterfrom
Open
Try to load the sha from tags if the branch can't be found#9BestFriendChris wants to merge 1 commit intowebsterclay:masterfrom
BestFriendChris wants to merge 1 commit intowebsterclay:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I modified the cookbook_github-install script to try to retrieve the sha from tags if it can't find it in the branches. For my personal workflow, this is important; I like to stick to tagged releases while periodically comparing with master (using
knife cookbook github compare) to see if I'm missing anything.Without this patch, I can install using tags, but the commit is screwed up: