Added React-Native templates#29
Open
MrigWed wants to merge 8 commits intowednesday-solutions:masterfrom
Open
Conversation
Author
|
|
Author
|
|
Feature/con com template
Author
|
|
Author
|
|
Author
|
|
Author
|
|
Author
|
|
Author
|
gtcon - command |
Author
|
|
Author
|
|
Author
|
|
Author
|
|
Author
|
|
Author
|
|
Author
|
|
girichetan
reviewed
Oct 9, 2020
bin/react-generate.js
Outdated
| @@ -190,7 +194,7 @@ switch (commandLineArgs[0]) { | |||
| shell.cd(cwd); | |||
| directories.forEach(component => { | |||
There was a problem hiding this comment.
let's call this container, just for clarification
Suggested change
| directories.forEach(component => { | |
| directories.forEach(container => { |
girichetan
reviewed
Oct 9, 2020
bin/react-native-generate.js
Outdated
| shell.cd(`./${commandLineArgs[1]}`); | ||
| directories = shell.ls(); | ||
| shell.cd(cwd); | ||
| directories.forEach(component => { |
There was a problem hiding this comment.
same here please, let's make this container
girichetan
reviewed
Oct 13, 2020
girichetan
left a comment
girichetan
left a comment
There was a problem hiding this comment.
some minor changes please check @MrigWed
…feature/con-com-template
girichetan
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Link
Related Links
Description
Steps to Reproduce / Test
GIF's