removed immutablejs for handling state immutability#37
Open
aniruddhagandhare wants to merge 22 commits intowednesday-solutions:masterfrom
Open
removed immutablejs for handling state immutability#37aniruddhagandhare wants to merge 22 commits intowednesday-solutions:masterfrom
aniruddhagandhare wants to merge 22 commits intowednesday-solutions:masterfrom
Conversation
alichherawalla
approved these changes
Jul 16, 2021
alichherawalla
requested changes
Jul 16, 2021
Contributor
alichherawalla
left a comment
alichherawalla
left a comment
There was a problem hiding this comment.
lets add a CD pipeline too
.github/workflows/npm-publish.yml
Outdated
| @@ -0,0 +1,33 @@ | |||
| # This workflow will run tests using node and then publish a package to GitHub Packages when a release is created | |||
.github/workflows/npm-publish.yml
Outdated
| # This workflow will run tests using node and then publish a package to GitHub Packages when a release is created | ||
| # For more information see: https://help.github.com/actions/language-and-framework-guides/publishing-nodejs-packages | ||
|
|
||
| name: Node.js Package |
.github/workflows/npm-publish.yml
Outdated
| - master | ||
|
|
||
| jobs: | ||
| build: |
Contributor
There was a problem hiding this comment.
this is just installing dependencies right, shouldn't be called build.
Also, we don't really need to install dependencies or build in this case.
.github/workflows/npm-publish.yml
Outdated
| with: | ||
| node-version: 14 | ||
| registry-url: https://registry.npmjs.org/ | ||
| - run: yarn install |
Contributor
There was a problem hiding this comment.
we're installing again here
aniruddhagandhare
force-pushed
the
master
branch
from
9e3ff11 to
f3288e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket Link
Related Links
Description
Steps to Reproduce / Test
GIF's