Skip to content

dockerfile and tsconfig to 24#353

Merged
agnesgaroux merged 6 commits intomainfrom
api-upgrade-node24
Feb 26, 2026
Merged

dockerfile and tsconfig to 24#353
agnesgaroux merged 6 commits intomainfrom
api-upgrade-node24

Conversation

@agnesgaroux
Copy link
Contributor

What does this change?

wellcomecollection/wellcomecollection.org#12411

How to test

Build image

docker build -f api/Dockerfile -t content-api .

Start container

docker run -p 3000:3000 \
  -v ~/.aws:/root/.aws:ro \
  -e AWS_PROFILE=catalogue-developer \
  content-api

-v ~/.aws:/root/.aws:ro \ gives the container read access to your aws creds

Go to
http://localhost:3000/all
http://localhost:3000/events

Results should be the same as All and Event and exhibitions tabs here https://wellcomecollection.org/search
Feel free to play around with filters, sort, etc

How can we measure success?

Content API runs happily on node 24

Have we considered potential risks?

The local and CI builds use the same Dockerfile, should be identical and run the same

@agnesgaroux agnesgaroux requested a review from a team as a code owner February 24, 2026 15:27
Copilot AI review requested due to automatic review settings February 24, 2026 15:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Content API service from Node 20 to Node 24 by updating the Docker base image and adding TypeScript configuration for Node 24. The changes are focused specifically on the api/ workspace within this monorepo, not the entire codebase.

Changes:

  • Updated api/Dockerfile to use Node 24 base image
  • Added @tsconfig/node24 dependency to both root and api package.json files
  • Automated yarn.lock updates reflecting the new dependencies

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
api/Dockerfile Updated base image from node:20 to node:24
package.json Added @tsconfig/node24@24.0.4 to root devDependencies
api/package.json Added @tsconfig/node24@24.0.4 and invalid JSON comments
yarn.lock Automated lock file updates for new dependencies and optimizations
Comments suppressed due to low confidence (1)

api/package.json:43

  • JSON files do not support comments. These JavaScript-style comments will cause a JSON parsing error and prevent the package.json file from being read correctly. Remove these lines and consider placing the documentation in the README or a separate documentation file instead.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@davidpmccormick davidpmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it says it does 💅

@agnesgaroux agnesgaroux merged commit 6ace17d into main Feb 26, 2026
5 checks passed
@agnesgaroux agnesgaroux deleted the api-upgrade-node24 branch February 26, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants