Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Content API service from Node 20 to Node 24 by updating the Docker base image and adding TypeScript configuration for Node 24. The changes are focused specifically on the api/ workspace within this monorepo, not the entire codebase.
Changes:
- Updated api/Dockerfile to use Node 24 base image
- Added
@tsconfig/node24dependency to both root and api package.json files - Automated yarn.lock updates reflecting the new dependencies
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/Dockerfile | Updated base image from node:20 to node:24 |
| package.json | Added @tsconfig/node24@24.0.4 to root devDependencies |
| api/package.json | Added @tsconfig/node24@24.0.4 and invalid JSON comments |
| yarn.lock | Automated lock file updates for new dependencies and optimizations |
Comments suppressed due to low confidence (1)
api/package.json:43
- JSON files do not support comments. These JavaScript-style comments will cause a JSON parsing error and prevent the package.json file from being read correctly. Remove these lines and consider placing the documentation in the README or a separate documentation file instead.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
95e8b13 to
91e592f
Compare
052e84a to
aa25cad
Compare
davidpmccormick
approved these changes
Feb 25, 2026
Contributor
davidpmccormick
left a comment
There was a problem hiding this comment.
Does what it says it does 💅
9a26e1f to
b34d4c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
wellcomecollection/wellcomecollection.org#12411
How to test
Build image
Start container
-v ~/.aws:/root/.aws:ro \gives the container read access to your aws credsGo to
http://localhost:3000/all
http://localhost:3000/events
Results should be the same as All and Event and exhibitions tabs here https://wellcomecollection.org/search
Feel free to play around with filters, sort, etc
How can we measure success?
Content API runs happily on node 24
Have we considered potential risks?
The local and CI builds use the same Dockerfile, should be identical and run the same