Conversation
There was a problem hiding this comment.
Pull request overview
This pull request upgrades the Unpublisher service from Node 20 to Node 24, aligns the @types/node version between the API and Unpublisher services, and adds .nvmrc files to both services to support multiple Node versions across the repository during the transitional period.
Changes:
- Upgraded Unpublisher's Dockerfile from Node 20 to Node 24
- Updated Unpublisher's package.json to use
@tsconfig/node24and @types/node@^24.10.13 - Aligned API's
@types/nodeversion from ^24.1.0 to ^24.10.13 to match Unpublisher - Added .nvmrc files specifying v24.13.0 for both API and Unpublisher services
- Updated README.md to expand the Content API description with additional endpoints and content types
- Updated yarn.lock with corresponding dependency changes
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| unpublisher/Dockerfile | Updated base image from Node 20 to Node 24 |
| unpublisher/package.json | Updated to @tsconfig/node24 and @types/node@^24.10.13 |
| unpublisher/.nvmrc | Added .nvmrc file specifying v24.13.0 |
| api/package.json | Updated @types/node from ^24.1.0 to ^24.10.13 for alignment |
| api/.nvmrc | Added .nvmrc file specifying v24.13.0 |
| yarn.lock | Updated dependency lockfile reflecting @types/node version changes |
| README.md | Expanded Content API description with additional endpoints and content types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| "devDependencies": { | ||
| "@tsconfig/node20": "20.1.8", | ||
| "@tsconfig/node24": "24.0.4", |
There was a problem hiding this comment.
The unpublisher package.json has been updated to use @tsconfig/node24, but the unpublisher/tsconfig.json extends ../tsconfig.base.json which still references @tsconfig/node20. This means the unpublisher will still be using Node 20 TypeScript configuration despite the dependency change. Either:
- Update tsconfig.base.json to extend
@tsconfig/node24(if all services are moving to Node 24), or - Change unpublisher/tsconfig.json to extend
@tsconfig/node24directly (like api/tsconfig.json does)
Note that the API uses approach #2 (extending @tsconfig/node24 directly), so for consistency, the unpublisher should likely do the same.
| "@tsconfig/node24": "24.0.4", | |
| "@tsconfig/node20": "20.1.4", |
What does this change?
Upgrade Unpublisher's node to 24.
Align the API packages and add .nvmrc files for while we have varied node versions across the repo.
How to test
The tests pass,
yarn devandyarn packagework smoothly as well.How can we measure success?
By being up to date
Have we considered potential risks?
Probably there are some but nothing we can't handle if they do end up existing.