Node 24

.github/dependabot.yml

@@ -11,9 +11,6 @@ updates:
       interval: 'monthly'
     ignore:
       - dependency-name: '@elastic/elasticsearch'
-      # Needs Node >= 20.15, update when we get there.
-      - dependency-name: '@types/node'
-      - dependency-name: 'lint-staged'
     groups:
       all:
         patterns: ['*']

.github/workflows/tsc.yml

@@ -16,6 +16,6 @@ jobs:
         # However, it is recommended to always specify Node.js version and don't rely on the system one.
         uses: actions/setup-node@v6
         with:
-          node-version: 20
+          node-version: 24
       - name: yarn tsc
         run: yarn install && yarn tsc

.nvmrc

@@ -1 +1 @@
-v20.15.0
+v24.13.0

README.md

@@ -1,6 +1,6 @@
 # Content API
 
-These are the services that back our [Content API](https://developers.wellcomecollection.org/api/content). The Content API exposes our non-catalogue content: at the moment, that's just articles, but in the future it might include endpoints for events, exhibitions, and functional content.
+These are the services that back our [Content API](https://developers.wellcomecollection.org/api/content). The Content API exposes our non-catalogue content. There are endpoints for `articles`, `events`, and `all` (where `all` includes articles, books, events, exhibitions, exhibition texts, exhibition highlight tours (BSL), exhibition highlight tours (audio), pages, projects, seasons, and visual stories).
 
 ![Architecture diagram](https://github.com/wellcomecollection/content-api/assets/4429247/b29a6bf5-f5af-426c-b827-550b84c5541c)
 

api/Dockerfile

@@ -1,5 +1,5 @@
 # Build this with the repo root as the build context
-FROM public.ecr.aws/docker/library/node:24
+FROM public.ecr.aws/docker/library/node:24.13.0
 
 WORKDIR /app
 

api/package.json

@@ -24,7 +24,7 @@
     "@types/jest": "^30.0.0",
     "@types/luxon": "^3.7.1",
     "@types/morgan": "^1.9.10",
-    "@types/node": "^24.1.0",
+    "@types/node": "^24.10.13",
     "@types/supertest": "^6.0.3",
     "jest": "^30.2.0",
     "jest-extended": "^7.0.0",

common/tsconfig.json

@@ -1,5 +1,5 @@
 {
-  "extends": "@tsconfig/node20/tsconfig.json",
+  "extends": "@tsconfig/node24/tsconfig.json",
   "compilerOptions": {
     "rootDir": ".",
     "moduleResolution": "node",

infrastructure/pipeline_stack/elastic_cluster.tf

@@ -1,5 +1,6 @@
 locals {
-  elastic_cloud_region = data.aws_region.current.name
+  # Use 'id' instead of deprecated 'name' for aws_region data source (id returns the region name, e.g., 'eu-west-1')
+  elastic_cloud_region = data.aws_region.current.id
   cluster_id           = ec_deployment.content_cluster.elasticsearch[0].resource_id
   cluster_alias        = ec_deployment.content_cluster.alias
   cluster_public_host  = "${local.cluster_alias}.es.${local.elastic_cloud_region}.aws.found.io"

infrastructure/pipeline_stack/pipeline_lambda.tf

@@ -6,7 +6,7 @@ module "pipeline_lambda" {
   source = "git@github.com:wellcomecollection/terraform-aws-lambda?ref=v1.2.0"
 
   name    = local.pipeline_lambda_name
-  runtime = "nodejs20.x"
+  runtime = "nodejs24.x"
   handler = "lambda.handler"
 
   filename    = data.archive_file.empty_zip.output_path

infrastructure/pipeline_stack/scheduled_window_event.tf

@@ -28,11 +28,14 @@ resource "aws_scheduler_schedule" "windows" {
 resource "aws_iam_role" "scheduler" {
   name               = "concept-pipeline-windows-${var.pipeline_date}"
   assume_role_policy = data.aws_iam_policy_document.scheduler_assume_role.json
+}
 
-  inline_policy {
-    name   = "invoke-lambda"
-    policy = data.aws_iam_policy_document.scheduler_invoke_lambda.json
-  }
+# aws_iam_role_policy is used instead of the deprecated inline_policy block above.
+# This is the recommended way to attach policies to roles in Terraform 1.x and later.
+resource "aws_iam_role_policy" "scheduler_invoke_lambda" {
+  name   = "invoke-lambda"
+  role   = aws_iam_role.scheduler.id
+  policy = data.aws_iam_policy_document.scheduler_invoke_lambda.json
 }
 
 data "aws_iam_policy_document" "scheduler_assume_role" {

infrastructure/pipeline_stack/unpublisher_lambda.tf

@@ -7,7 +7,7 @@ module "unpublisher_lambda" {
 
   name        = local.unpublisher_lambda_name
   description = "Handle any documents which are 'unpublished' (deleted) in Prismic"
-  runtime     = "nodejs20.x"
+  runtime     = "nodejs24.x"
   handler     = "lambda.handler"
 
   filename    = data.archive_file.empty_zip.output_path

infrastructure/prismic-snapshots/lambda_backup_download.tf

@@ -8,7 +8,7 @@ resource "aws_lambda_function" "prismic_backup_download" {
   function_name = local.lambda_backup_download_name
   role          = aws_iam_role.prismic_backup_download_lambda_role.arn
   handler       = "index.handler"
-  runtime       = "nodejs20.x"
+  runtime       = "nodejs24.x"
   timeout       = 900 # 15 minutes
   memory_size   = 1024
 

infrastructure/prismic-snapshots/lambda_backup_trigger.tf

@@ -8,7 +8,7 @@ resource "aws_lambda_function" "prismic_backup_trigger" {
   function_name = local.lambda_backup_trigger_name
   role          = aws_iam_role.prismic_backup_trigger_lambda_role.arn
   handler       = "index.handler"
-  runtime       = "nodejs20.x"
+  runtime       = "nodejs24.x"
   timeout       = 900 # 15 minutes
   memory_size   = 1024
 

infrastructure/prismic-snapshots/lambda_snapshot.tf

@@ -8,7 +8,7 @@ resource "aws_lambda_function" "prismic_snapshot" {
   function_name = local.lambda_snapshot_name
   role          = aws_iam_role.prismic_snapshot_lambda_role.arn
   handler       = "index.handler"
-  runtime       = "nodejs20.x"
+  runtime       = "nodejs24.x"
   timeout       = 900 # 15 minutes
   memory_size   = 1024
 

infrastructure/terraform.tf

@@ -13,7 +13,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 4.58.0"
+      version = ">= 5.31.0"
     }
     ec = {
       source = "elastic/ec"

infrastructure/webhook_stack/lambda.tf

@@ -7,7 +7,7 @@ module "webhook_lambda" {
   source = "git@github.com:wellcomecollection/terraform-aws-lambda?ref=v1.2.0"
 
   name    = local.lambda_name
-  runtime = "nodejs20.x"
+  runtime = "nodejs24.x"
   handler = "lambda.handler"
 
   filename    = data.archive_file.empty_zip.output_path

package.json

@@ -23,7 +23,6 @@
   "devDependencies": {
     "@babel/eslint-parser": "^7.28.6",
     "@eslint/js": "^9.39.2",
-    "@tsconfig/node20": "20.1.8",
     "@tsconfig/node24": "24.0.4",
     "@typescript-eslint/eslint-plugin": "^8.54.0",
     "@typescript-eslint/parser": "^8.54.0",

pipeline/Dockerfile

@@ -1,5 +1,5 @@
 # Build this with the repo root as the build context
-FROM public.ecr.aws/docker/library/node:20
+FROM public.ecr.aws/docker/library/node:24.13.0
 
 WORKDIR /app
 

pipeline/package.json

@@ -22,10 +22,10 @@
     "rxjs": "^7.8.0"
   },
   "devDependencies": {
-    "@tsconfig/node20": "20.1.8",
+    "@tsconfig/node24": "24.0.4",
     "@types/aws-lambda": "^8.10.160",
     "@types/jest": "^30.0.0",
-    "@types/node": "^20.16.5",
+    "@types/node": "^24.10.13",
     "esbuild": "^0.27.2",
     "jest": "^30.2.0",
     "jest-extended": "^7.0.0",

pipeline/package.sh

@@ -6,7 +6,7 @@ set -o pipefail
 yarn run esbuild ./src/lambda.js \
   --bundle \
   --platform=node \
-  --target=node20 \
+  --target=node24 \
   --sourcemap=external \
   --outdir=dist
 

tooling.Dockerfile

@@ -1,4 +1,4 @@
-FROM public.ecr.aws/docker/library/node:20
+FROM public.ecr.aws/docker/library/node:24.13.0
 
 # Install Terraform (for formatting)
 ARG TERRAFORM_VERSION=1.4.0

tsconfig.base.json

@@ -1,5 +1,5 @@
 {
-  "extends": "@tsconfig/node20/tsconfig.json",
+  "extends": "@tsconfig/node24/tsconfig.json",
   "compilerOptions": {
     "noEmit": true,
     "moduleResolution": "node",

unpublisher/Dockerfile

@@ -1,5 +1,5 @@
 # Build this with the repo root as the build context
-FROM public.ecr.aws/docker/library/node:20
+FROM public.ecr.aws/docker/library/node:24.13.0
 
 WORKDIR /app
 

unpublisher/package.json

@@ -14,10 +14,10 @@
     "zod": "^4.3.6"
   },
   "devDependencies": {
-    "@tsconfig/node20": "20.1.8",
+    "@tsconfig/node24": "24.0.4",
     "@types/aws-lambda": "^8.10.160",
     "@types/jest": "^30.0.0",
-    "@types/node": "^20.16.5",
+    "@types/node": "^24.10.13",
     "dotenv": "^17.2.3",
     "esbuild": "^0.27.2",
     "jest": "^30.2.0",

unpublisher/package.sh

@@ -6,7 +6,7 @@ set -o pipefail
 yarn run esbuild ./src/lambda.js \
   --bundle \
   --platform=node \
-  --target=node20 \
+  --target=node24 \
   --sourcemap=external \
   --outdir=dist
 

webhook/Dockerfile

@@ -1,5 +1,5 @@
 # Build this with the repo root as the build context
-FROM public.ecr.aws/docker/library/node:20
+FROM public.ecr.aws/docker/library/node:24.13.0
 
 WORKDIR /app
 

webhook/package.json

@@ -13,10 +13,10 @@
     "@weco/content-common": "*"
   },
   "devDependencies": {
-    "@tsconfig/node20": "20.1.8",
+    "@tsconfig/node24": "24.0.4",
     "@types/aws-lambda": "^8.10.160",
     "@types/jest": "^30.0.0",
-    "@types/node": "^20.16.5",
+    "@types/node": "^24.10.13",
     "esbuild": "^0.27.2",
     "jest": "^30.2.0",
     "ts-jest": "^29.4.6",

webhook/package.sh

@@ -6,7 +6,7 @@ set -o pipefail
 yarn run esbuild ./src/lambda.js \
   --bundle \
   --platform=node \
-  --target=node20 \
+  --target=node24 \
   --sourcemap=external \
   --outdir=dist