Open
Conversation
The logdir option allows for specifying where to look for logs to process instead of always looking and creating in /tmp.
It is possible for argv to be NULL at this point, it is guarded against in other places in this function. Make sure we guard at this point as well.
When we allow users to set the log directory we need to allocate more room for the logs.
Using strncat is prone to buffer overflow errors.
For long unsigned we should use "%lu" not "%d".
In order to conform to Make's coding style.
The eval function in make can be called explicit for an $(eval) function. This can occur outside of a [START|END] EVAL MAKEFILE and we can't handle that.
When analyzing a big project it's nice to be able to skip rebuilding and instead process the logs that are already there.
Sending all logs as arguments to system('rm') risks failing
with 'too many arguments'.
To avoid forking to a new process and to be sure that we retain the permissions of the file.
Add a commandline option to determine where to generate the visualization pages to and start the webserver from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on larger projects with build times in the hours it is nice to have some ways to avoid re-building the code and avoid re-processing the logs. These commits add some command line options that are consumed by vizmake.py before they reach make. These options can tell vizmake.py to not re-build or not to re-process.
A --logdir option is also added to be able to tell vizmake where to store logs. Larger projects can generate gigabytes of logs and sometimes the /tmp partition can't handle that.
When adding the logdir option we also need to make sure that make has buffers large enough to handle a path passed.
Also in this pull-request are some fixes for issues I ran into while trying this on a large build.
Thanks
Jonas