Skip to content

fix: calling scroll methods without window context #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gretzkiy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: calling scroll methods without window context #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/patch/window/scroll-by.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {handleScrollMethod} from "../shared";
* Patches the 'scrollBy' method on the Window prototype
*/
export function patchWindowScrollBy(): void {
window.scrollBy = function(this: Window, optionsOrX?: number | ScrollToOptions, y?: number): void {
handleScrollMethod(this, "scrollBy", optionsOrX, y);
window.scrollBy = function(this: Window | undefined, optionsOrX?: number | ScrollToOptions, y?: number): void {
handleScrollMethod(this ?? window, "scrollBy", optionsOrX, y);
};
}
4 changes: 2 additions & 2 deletions src/patch/window/scroll-to.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {handleScrollMethod} from "../shared";
* Patches the 'scrollTo' method on the Window prototype
*/
export function patchWindowScrollTo(): void {
window.scrollTo = function(this: Window, optionsOrX?: number | ScrollToOptions, y?: number): void {
handleScrollMethod(this, "scrollTo", optionsOrX, y);
window.scrollTo = function(this: Window | undefined, optionsOrX?: number | ScrollToOptions, y?: number): void {
handleScrollMethod(this ?? window, "scrollTo", optionsOrX, y);
};
}
4 changes: 2 additions & 2 deletions src/patch/window/scroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {handleScrollMethod} from "../shared";
* Patches the 'scroll' method on the Window prototype
*/
export function patchWindowScroll(): void {
window.scroll = function(this: Window, optionsOrX?: number | ScrollToOptions, y?: number): void {
handleScrollMethod(this, "scroll", optionsOrX, y);
window.scroll = function(this: Window | undefined, optionsOrX?: number | ScrollToOptions, y?: number): void {
handleScrollMethod(this ?? window, "scroll", optionsOrX, y);
};
}