fix(bug): hash may contain a string that is not a selector#22
Open
chrishoage wants to merge 1 commit intowessberg:masterfrom
Open
fix(bug): hash may contain a string that is not a selector#22chrishoage wants to merge 1 commit intowessberg:masterfrom
chrishoage wants to merge 1 commit intowessberg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #21
Following up from the GHI I have gone ahead and went with the try/catch route. If you'd prefer a regex that checks the hash to see if it looks like an ID I'd be happy to adjust