Add clj-kondo inline macro configuration#34
Open
lyallcooper wants to merge 1 commit intowhamtet:mainfrom
Open
Conversation
Versions of clj-kondo since `2023.03.17` support [inline macro configuration](https://github.com/clj-kondo/clj-kondo/blob/master/doc/config.md#inline-macro-configuration). We can use this to prevent annoying linting errors from popping up when using `defcomponent` etc. without having to add anything to our clj-kondo config. I'm not sure I've chosen the best config options here though, so please double check them.
Author
|
Apologies, on closer inspection of the clj-kondo docs it seems like this won't magically fix the errors without downstream users still having to the incantation of: Which as far as I can tell is the same as the current situation 😕 However, this still might be an improvement over the status quo since IMHO it's a little clearer to put the lint instructions with the functions than it is to have them buried in a separate config file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Versions of clj-kondo since
2023.03.17support inline macro configuration. We can use this to prevent annoying linting errors from popping up when usingdefcomponentetc. without having to add anything to our clj-kondo config.I'm not sure I've chosen the best config options here though, so please double check them.