Append the serialization of URL to inputs when performing a match #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list `inputs` is an array of `URLPatternInput` which can only be either a `USVString` or a `URLPatternInit`. To handle the case where a URL is passed through, we need to append the serialization of that URL.
shannonbooth
force-pushed
the
url-serialization
branch
from
bf714ce to
05eb312
Compare
annevk
reviewed
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list
inputsis an array ofURLPatternInputwhich can onlybe either a
USVStringor aURLPatternInit. To handle the casewhere a URL is passed through, we need to append the serialization
of that URL.
This was the source of my confusion in #264 as I was thinking it could only be a URLPatternInput.
Preview | Diff