Open
Conversation
ivasilov
reviewed
Sep 8, 2023
| json_output = json.dumps(txns,indent=4) | ||
| print(json_output) | ||
| elif output_format == 'csv': | ||
| if input_type == "accounts": |
There was a problem hiding this comment.
Can you handle transactions here also? The nlbcli accounts XXX transactions --format csv doesn't print anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it only works for
nlbcli accounts [id] balance, but it can easily be made to work as an argument for any command, as long as theprintstatements are replaced withformatter.OutputResult()or something similar.Because it only works for
accounts [id] balance,OutputResultis hardwired to do the print statements for that operation, although I am working on a way to pass it a dictionary of values to be printed instead so as to universalize it.Feedback is of course appreciated, and so are contributions/commits.
Demonstration of current capabilities:
