Skip to content

use browser built-in options_ui #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shinenelson wants to merge 5 commits into
base: master
Choose a base branch
from
Open

use browser built-in options_ui #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
84c86cb
stop opening options_ui in new tab
shinenelson Apr 10, 2021
93185c0
remove logo and header
shinenelson Apr 10, 2021
c573c08
remove cruft styles
shinenelson Apr 10, 2021
a8d6ec3
use browser-style for options_ui elements
shinenelson Apr 10, 2021
e2d7080
update changelog
shinenelson Apr 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Changelog
=========

### unreleased
- use browser built-in `options_ui`

### v1.7.2 / 2020-10-30

- Fix contribution graph and progress bar colors (new GitHub CSS variables)
Expand Down
51 changes: 6 additions & 45 deletions src/css/options.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,67 +1,28 @@
body {
background-color: #EEE;
font-family: arial, sans-serif;
font-size: 13px
}

#content {
background-color: white;
border: 1px solid #DDD;
margin: 40px auto 20px;
padding: 12px;
width: 500px;
-webkit-border-radius: 12px;
box-shadow: 0px 0px 10px #DDD;
}

#logo {
margin: -5px 10px -5px 0;
width: 32px;
float: left;
}

h1 {
color: #333;
font-size: 1.5em;
margin: 0.7em 0 0;
}

#header {
background: linear-gradient(white, #EEE);
padding: 15px 0px 10px 10px;
height: 30px;
border-bottom: 1px solid #DDD;
margin: -12px -12px 20px -12px;
border-top-left-radius: 10px;
border-top-right-radius: 10px;
text-shadow: 1px 1px 1px white;
color: #666;
margin: 1em auto;
text-align: center;
}

p {
font-size: 12px;
#content span {
margin-right: 1em;
}

hr {
border: 1px solid #EEE;
border-bottom: none;
margin: 10px 0px;
}

#status {
color: green;
text-align: center;
margin: auto;
}

button {
cursor: pointer;
background-image: linear-gradient(white, #EEE);
color: #333;
border: 1px solid #CCC;
border-radius: 2px;
margin: 0px 1px 0px 0px;
outline: none;
min-height: 2em;
text-align: center;
}

button:hover {
Expand Down
3 changes: 1 addition & 2 deletions src/manifest.firefox.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
}],

"options_ui": {
"page": "options.html",
"open_in_tab": true
"page": "options.html"
},

"permissions": [
Expand Down
3 changes: 1 addition & 2 deletions src/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
}],

"options_ui": {
"page": "options.html",
"open_in_tab": true
"page": "options.html"
},

"permissions": [
Expand Down
11 changes: 3 additions & 8 deletions src/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,8 @@

<body>
<div id="content">
<img id="logo" src="images/icon-48.png" alt="logo" />
<h1 id="header">GitHub Contribution Color Graph Options</h1>

<p>Choose graph color</p>
<p>
<select id="color">
<span>Graph Color</span>
<select class="browser-style" id="color">
<option value="github">GitHub Default</option>
<option value="halloween">Halloween</option>
<option disabled>──────────</option>
Expand Down Expand Up @@ -47,11 +43,10 @@ <h1 id="header">GitHub Contribution Color Graph Options</h1>
<option disabled>──────────</option>
<option value="random">Random</option>
</select>
</p>

<hr />

<button id="save">Save my preference</button>
<button class="browser-style" id="save">Save preference</button>
<span id="status"></span>
</div>

Expand Down