Change computeAddress Visibility to internal#3
Open
nlordell wants to merge 1 commit intowilsoncusack:mainfrom
Open
Change computeAddress Visibility to internal#3nlordell wants to merge 1 commit intowilsoncusack:mainfrom
computeAddress Visibility to internal#3nlordell wants to merge 1 commit intowilsoncusack:mainfrom
Conversation
This PR changes the visibility of the `computeAddress` library functions to be `internal`. Library functions that are `public` generate code to call to an external library contract. This causes some inconveniences, for example uses of `computeAddress` with `forge script` to potentially broadcast a transaction to deploy the `SafeSingletonDeployer` library (even if it isn't actually needed).
crypto3699
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the visibility of the
computeAddresslibrary functions to beinternal. Library functions that arepublicgenerate code to call to an external library contract.This causes some inconveniences, for example uses of
computeAddresswithforge scriptto potentially broadcast a transaction to deploy theSafeSingletonDeployerlibrary (even if it isn't actually needed).