feat: implement quiet mode to filter verbose logs #7478
+45
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add QUIET_MODE environment variable (set to "true" or "1" to enable) that: - Filters logs with the "windmill_verbose" target via tracing_init - Increases frequency of periodic logs by 10x when enabled - Marks per-job worker logs as verbose so they are suppressed in quiet mode Key changes: - Add QUIET_MODE lazy_static and VERBOSE_TARGET constant to tracing_init.rs - Create create_targets_filter() helper that filters windmill_verbose target - Mark periodic "still running" and "memory snapshot" logs with VERBOSE_TARGET - Mark per-job "fetched job", "started handling", "job finished" logs as verbose - Increase memory snapshot interval from every 10 ticks to every 100 ticks in quiet mode - Increase "still running" log interval from every tick to every 10 ticks in quiet mode - Add quiet mode notification in job logs Closes #7477 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: windmill-internal-app[bot] <windmill-internal-app[bot]@users.noreply.github.com>
Deploying windmill with
|
| Latest commit: |
242a0ff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7a2cc5fa.windmill.pages.dev |
| Branch Preview URL: | https://claude-issue-7477-20260102-0.windmill.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
QUIET_MODEenvironment variable (set to"true"or"1"to enable) that filters noise logswindmill_verbosetarget that gets filtered in quiet modeChanges
backend/windmill-common/src/tracing_init.rsQUIET_MODElazy_static env varVERBOSE_TARGETconstant ("windmill_verbose") for logs that should be suppressedcreate_targets_filter()helper that filters the verbose target when quiet mode is onbackend/windmill-worker/src/handle_child.rsVERBOSE_TARGET:backend/windmill-worker/src/worker.rsVERBOSE_TARGET:Test plan
QUIET_MODE=trueand verify verbose logs are suppressedQUIET_MODEand verify all logs appear normallyCloses #7477
🤖 Generated with Claude Code