fix: app re-authenticates with email/password instead of SSO - WPB-22220 #4057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When their session expires and they need to re-authenticate, users that have an email address registered and use SSO are presented with the email / password authentication flow instead of the SSO authentication flow.
Cause
LoginCredentialshas a propertyhasPasswordthat is used to determine whether to use SSO or email & password authentication. However, this property is set toemail != nil. But some SSO users may have an email address, so it isn't accurate to assume that having an email necessarily means the user relies on email + password authentication.Solution
Remove the
hasPasswordproperty and rely on the existingusesCompanyLogin(translates tousesSSO) to check whether the user should authenticate via SSOTesting
The app should redirect to the SSO authentication flow
Checklist
[WPB-XXX].