[ui] Adjust the light direction in BlockComponent#313
Open
Zailer43 wants to merge 1 commit intowisp-forest:1.21from
Open
[ui] Adjust the light direction in BlockComponent#313Zailer43 wants to merge 1 commit intowisp-forest:1.21from
Zailer43 wants to merge 1 commit intowisp-forest:1.21from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Although the lighting now has less contrast on one side, it's also less saturated on the other, and there are blocks that don't appear strangely dark. I couldn't find values that achieve a similar contrast while preventing some blocks from appearing dark
If anyone can find values that match better with vanilla, I would appreciate it
Comparison
Screenshots
BeforeThis PR
Vanilla
Screenshots with zoom
BeforeThis PR
Vanilla
Fix #157