-
Notifications
You must be signed in to change notification settings - Fork 16
Fix crashes on 1.18.2 #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bob74
wants to merge
18
commits into
wisp-forest:1.18.2
Choose a base branch
from
Bob74:1.18.2
base: 1.18.2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1c8cc73
Update README.md
Bob74 5cc1b43
Update README.md
Bob74 e98cfdb
add deepslate glowstone fixture + typo
Bob74 a5accda
add deepslate glowstone fixture + typo
Bob74 9eb857f
Using Maldenhagen class from owo-lib instead of Copenhagen to avoid c…
Bob74 daef43c
Merge branch '1.18.2' of https://github.com/Bob74/things-1.18.2-fix i…
Bob74 bba0e8c
Update README.md
Bob74 2e49153
Update README.md
Bob74 272fecf
Update README.md
Bob74 13b8bbe
Update README.md
Bob74 e108672
Update README.md
Bob74 20cfb6d
Set mod version to 0.2.19
Bob74 8c8d816
Merge branch '1.18.2' of https://github.com/Bob74/things-1.18.2-fix i…
Bob74 f3cbf1c
Added local gradle repository
Bob74 e8d5d64
Added local gradle repository
Bob74 75dc9f8
Put back original README
Bob74 abf022c
Put back original README
Bob74 fc25df1
removing libs
Bob74 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
src/main/resources/assets/things/blockstates/deepslate_glowstone_fixture.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "variants": { | ||
| "facing=down": { | ||
| "model": "things:block/deepslate_glowstone_fixture" | ||
| }, | ||
| "facing=up": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 180 | ||
| }, | ||
| "facing=west": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90, | ||
| "y": 90 | ||
| }, | ||
| "facing=east": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90, | ||
| "y": 270 | ||
| }, | ||
| "facing=south": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90 | ||
| }, | ||
| "facing=north": { | ||
| "model": "things:block/deepslate_glowstone_fixture", | ||
| "x": 90, | ||
| "y": 180 | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this too? and some other stuff to be able to merge it in upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, it won't compile without local libs since they aren't available on maven.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way you have it currently it won't compile either, since you didn't check the libs directory into source control. In any case, I'd much prefer this to use the actual maven, if and when I publish the backported owo version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well it did build that way but I agree ot would be a lot better to get the libs from maven.