update ledger rpc #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds the new Ledger-to-JSON-RPC Processor, including its documentation, Protobuf definitions, mocks, server implementation, Flow control-plane integration, build scripts, and containerization.
- Introduces
ttp-processor/README.mdand updates FlowCTL integration guide for deployment, monitoring, and management - Adds Protobuf service and event definitions under
ledger-jsonrpc-processor/protosand corresponding Go mocks - Implements the gRPC server, FlowCTL controller, CLI entrypoint, Makefile, Dockerfile, and go.work configuration
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ttp-processor/README.md | New project overview, features, configuration, API, health checks, and Flow integration summary |
| ttp-processor/FLOWCTL_INTEGRATION.md | Revised Flow control-plane integration guide for Ledger-to-JSON-RPC Processor |
| ledger-jsonrpc-processor/protos/... | Protobuf definitions for RPC service and JSON-RPC events |
| ledger-jsonrpc-processor/mocks | Mock implementations for Stellar XDR and FlowCTL control-plane client |
| ledger-jsonrpc-processor/go/server | FlowCTL controller (ledger_jsonrpc_flowctl.go) and gRPC server glue code |
| ledger-jsonrpc-processor/go/main.go | CLI entrypoint wiring environment config, health server, and optional FlowCTL integration |
| ledger-jsonrpc-processor/Makefile | Build/test/proto targets, Docker image staging |
| ledger-jsonrpc-processor/Dockerfile | Multi-stage container build for the processor |
| ledger-jsonrpc-processor/docs/FLOWCTL_INTEGRATION.md | Duplicate FlowCTL integration guide in docs/ |
| go.work | Adds ./ledger-jsonrpc-processor to workspace |
Comments suppressed due to low confidence (1)
ledger-jsonrpc-processor/FLOWCTL_INTEGRATION.md:1
- [nitpick] This file duplicates the guide under
docs/FLOWCTL_INTEGRATION.md. Consolidate or remove one copy to avoid split documentation.
# Flow Control Plane Integration Guide for Ledger-to-JSON-RPC Processor
| $(PROTO_DIR)/ledger_jsonrpc_service/ledger_jsonrpc_service.proto | ||
|
|
||
| # Generate protobuf code for the raw ledger service (dependency) | ||
| $(PROTOC) --proto_path=$(PROTO_DIR) \ |
There was a problem hiding this comment.
The proto target references raw_ledger_service/raw_ledger_service.proto, but that directory/file does not exist under protos. Update the path or include the correct proto sources so the build succeeds.
| | `ENABLE_JSON_XDR` | Enable JSON XDR format optimization | false | | ||
| | `ENABLE_FLOWCTL` | Enable integration with flowctl control plane | false | | ||
| | `FLOWCTL_ENDPOINT` | The endpoint for the flowctl control plane | localhost:8080 | | ||
| | `FLOWCTL_HEARTBEAT_INTERVAL` | Interval for sending heartbeats to flowctl | 10s | |
There was a problem hiding this comment.
The FlowCTL controller code reads STELLAR_NETWORK for metadata, but STELLAR_NETWORK is not documented in this README. Add it to the environment variable table to avoid confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ledger to RPC processor