This repository was archived by the owner on Oct 11, 2022. It is now read-only.
Open
Conversation
… line following after style
mxstbr
suggested changes
Oct 27, 2018
mxstbr
left a comment
mxstbr
left a comment
There was a problem hiding this comment.
💯
Mind adding a test for this so we don't accidentally break it again?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found another issue with unsticking styles:
Doing previous PR #141 I forgot that we also clear styles on the starting of the new line https://github.com/withspectrum/draft-js-markdown-plugin/blob/master/src/index.js#L373 and
unstickyInlineStylesfunction in that case should work even if the previous block styles were changed by another plugin.