This repository was archived by the owner on Oct 11, 2022. It is now read-only.
DraftJS v0.11.x Support#186
Open
thecodedrift wants to merge 5 commits intowithspectrum:masterfrom
thecodedrift:jakobo/draftv0.11
Open
DraftJS v0.11.x Support#186thecodedrift wants to merge 5 commits intowithspectrum:masterfrom thecodedrift:jakobo/draftv0.11
thecodedrift wants to merge 5 commits intowithspectrum:masterfrom
thecodedrift:jakobo/draftv0.11
Conversation
To support DraftJS v0.11.x forward, handleBeforeInput needs to take an additional parameter `eventTimestamp` for synchronizing collaborative actions. This change adds support for eventTimestamp, updates all tests and snapshots, and updates the peerDependencies to match. BREAKING CHANGE: The changes to DraftJS and draft-js-plugin-editor are not backwards compatible with the 0.10.x/2.0.0 versions respectively. The peerDependencies were updated to reflect this and a note was added to the readme.
Originally, I wanted to see if we could modify handleBeforeInput such that it would support both v0.10 and v0.11. Unfortunately, counting the number of args was unreliable when multiple plugins were involved. This test was made redundant by updating tests to require an event timestamp when calling handleBeforeInput
Somewhere in the fork, we opted to remove flowconfig from the repo. Travis was failing ever since this change. This is a simple removal so that we're passing CI regularly. A future change should restore flowconfig and the travis flow statement if we intend to use flow.
|
nice but it'd be easier to review if you removed all the random formatting changes. For anyone who is curious, there fix is just a small change which adds a single variable to the parameter list of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #181
To support DraftJS v0.11.x forward, handleBeforeInput needs to take an additional parameter
eventTimestampfor synchronizing collaborative actions. This change adds support for eventTimestamp, updates all tests and snapshots, and updates the peerDependencies to match.Contains stylistic changes triggered by saving with a
.prettierrc. Since it was complaining in vscode, I also fixed thesingleQuoteproperty to match the intended value from the prettier docs.BREAKING CHANGE: The changes to DraftJS and draft-js-plugin-editor are not backwards compatible with the 0.10.x/2.0.0 versions respectively. The peerDependencies were updated to reflect this and a note was added to the readme.
note: this PR is intentionally in smaller commits for the purpose of more efficient rebasing. At owner's request, I'm happy to squash these down to a single commit on approval & before merge. ❤️