fix: exclude build/ and tests/ from mypy to silence false-positive errors#50
Merged
fix: exclude build/ and tests/ from mypy to silence false-positive errors#50
Conversation
For MCP-backed tasklist providers (GitHub Issues, Linear), has_remaining_tasks() queries the remote and returns True whenever any open issue with the configured label exists — making --deliver unusable. Skip the guard for remote providers since new design/plan tasks are expected to coexist with existing issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…duplicate module errors mypy run from the repo root was reporting "Duplicate module named 'millstone'" (from build/) and "Source file found twice" (from tests/e2e/conftest.py), causing the --eval command to show 1 typing error even though the code is clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
millstone --evalrunsmypy .from the repo root and was reporting:Duplicate module named 'millstone'(caused bybuild/lib/millstone/frompip install -e .builds)Source file found twice: e2e.conftest and tests.e2e.conftest(fromtests/e2e/conftest.py)These are false positives — the actual source code has 0 type errors. Adding
exclude = ["build/", "dist/", "tests/"]to[tool.mypy]inpyproject.tomlclears them.Test plan
mypy .from repo root:Success: no issues found in 50 source filesmillstone --evalshowstyping: 1.00 (errors=0)andStatus: PASSED🤖 Generated with Claude Code