fix: use exit code to determine lint error count in --eval#51
Merged
Conversation
When a configured lint command runs successfully (exit code 0), treat error count as 0 regardless of output lines. Previously, informational output like ruff's "All checks passed!" was counted as 1 error, causing --eval to show lint: 0.99 even on a clean codebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This was referenced Mar 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
millstone --evalwas reportinglint: 0.99 (errors=1)on a clean codebase. Root cause:_run_lint()was counting all non-empty output lines as errors when a configuredlint_cmdwas used.ruff check .(the default Python project command) outputs"All checks passed!"on success — one non-empty line counted as 1 error.Fix: check exit code first. Exit code 0 → errors=0. Non-zero → count output lines as before.
Test plan
millstone --evalnow showslint: 1.00 (errors=0)on clean code🤖 Generated with Claude Code