Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ecsctrl/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,8 @@ def store(
"Value": value["Value"],
"Type": value["Type"],
}
if value.get("Description", None):
ssm_params["Description"] = value["Description"]

click.echo(f"🔑 Storing secret {secret_name}.")
response = ssm.call("put_parameter", **ssm_params)
Expand Down
9 changes: 7 additions & 2 deletions ecsctrl/dump/secrets.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import re
from . import substitute_with_expressions
from dataclasses import dataclass
from typing import Generator, Sequence
from typing import Generator, Optional, Sequence


@dataclass
class Parameter:
name: str
value: str
type: str
description: Optional[str]


def list_secrets(ssm):
Expand Down Expand Up @@ -41,6 +42,7 @@ def dump_secrets(ssm, filter=None) -> Generator[Parameter, None, None]:
name=parameter_name,
value=response["Parameter"]["Value"],
type=response["Parameter"]["Type"],
description=parameter.get("Description", None),
)


Expand All @@ -57,7 +59,7 @@ def render_dumped_secrets(click, secrets: Sequence[Parameter], vars_lut, target_
def rended_single_secret(parameter: Parameter, vars_lut):
name = parameter.name
key = substitute_with_expressions(name, vars_lut)
if parameter.type == "SecureString":
if parameter.type == "SecureString" and parameter.description is None:
secret_text = render_simple_secret(key, parameter)
else:
secret_text = render_complex_secret(key, parameter)
Expand All @@ -75,6 +77,9 @@ def render_complex_secret(key, parameter):
secret_text = f"{key}:\n"
secret_text += f" Type: {parameter.type}\n"
secret_text += f" Value: {value}\n"
if parameter.description:
description = render_value(parameter.description, 2)
secret_text += f" Description: {description}\n"
return secret_text


Expand Down