Skip to content

Conversation

@naugtur
Copy link

@naugtur naugtur commented Jul 7, 2020

  • changed the authorization function to accept anything and pass it to sp-auth to handle all methods supported.
  • added functions for getting the file metadata and content as stream
  • added functions for role management (not sure what they do, I'm figuring these calls out)
  • minor refactor of input checking

Any tips from people who know sharepoint would help.
I need to set single file permissions to single users and have no idea how to proceed yet :)

throw new Error('You must provide a username and password.')
async authenticate (credentials) {
if (!credentials) {
throw Error('Credentials are required')
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all new before Error because it doesn't do anything in Javascript really other than creating an unnecessary object in memory maybe.

@naugtur
Copy link
Author

naugtur commented Jul 9, 2020

Hi,

I needed much more features related to sharing and permissions, so I switched to pnpjs.
I no longer have the ability to finish this contribution in my working hours.

Feel free to merge just parts of it. I'd recommend removing the roles functionality and merging the rest if you don't want to continue the work on roles.

@jezhiggins
Copy link
Contributor

No worries 👍 Thanks for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants