-
Notifications
You must be signed in to change notification settings - Fork 77
[지하철 노선도 미션] 유건 미션 제출합니다. #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rjwu95
wants to merge
20
commits into
woowacourse:main
Choose a base branch
from
rjwu95:yugun
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SubwayMapManage class 생성 - map을 제외하고(요구사항 맞추기 위해) content 영역을 미리 생성 후 display 값으로 화면 표시 유무 결정 - map content는 지웠다가 매번 다시 생성
- 예외 상황 처리: 2자 이하, 이미 있는 역일 때
- 각각의 class를 작은 단위로 유지하기 위해
- 기능 요구 사항에 맞추기 위해
- line 이 추가됨에 따라 storage를 다양하게 사용해야하기 때문에
- 역 리스트의 값이 변할때보다 노선 내용이 보여질 때 select를 변경하는게 더 효율적이므로 눌렀을 때 변경
- 구조 가독성을 높이기 위해
- 예외 상황 처리(노선 이름 존재하는 경우, 종점이 둘다 같은 경우, 종점이 서로 같은 경우) - 메뉴 버튼 누를 때 역, 노선 table 렌더링
- 구간 선택 화면 뼈대를 template literal로 따로 분리
- line storage에 array로 저장하지 않고 object 형태로 변경
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3주차 미션 제출합니다.