-
Notifications
You must be signed in to change notification settings - Fork 83
[지하철 길찾기] 김인섭 미션 제출합니다. #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kiminseob
wants to merge
26
commits into
woowacourse:main
Choose a base branch
from
kiminseob:kiminseob
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 2 글자 이상이어야 한다는 조건이 빈값 예외 조건을 포함하므로 빈값 예외 조건 은 없앴음
- 출발역, 지하철역, 검색타입, 검색버튼 초기화
- table 둘레, 가운데 정렬 스타일 추가
- 클래스명도 Subway -> SubwayApp으로 변경
- sections 객체 distance 오탈자 수정
- addFindButtonListener 함수명 -> addSearchButtonListener - 길찾기 버튼 변수명 findButton -> searchButton
- 등록되지 않은 역들을 먼저 예외 처리 하기 때문에 노선에 연결되지 않은 역들은 없다. 그래서 해당 예외는 제거한다.
- subway.listener.js -> listener 폴더로 옮김 - subway.handler.js -> handler 폴더로 옮김 - subway.app.js, subway.validator.js -> app 폴더로 옮김 - subway.view.js -> view 폴더로 옮김
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge가 자동으로 안되네요..
그동안 고생많으셨습니다.
감사합니다.