Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR switches feedback rendering to markdown, updates a character’s question count, and adds a necessary dependency.
- Render general feedback using
react-markdowninstead of raw text. - Reduce
Yuzu'stotalQuestionfrom 5 to 1. - Add
react-markdownto project dependencies.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/webview/src/screens/general-feedback-screen/components/FeedbackBox.tsx | Replace Typography with ReactMarkdown for markdown support |
| frontend/src/webview/src/data/create-characters.ts | Change Yuzu's totalQuestion from 5 to 1 and reorder imports |
| frontend/package.json | Add react-markdown dependency |
Comments suppressed due to low confidence (1)
frontend/src/webview/src/data/create-characters.ts:12
- The
totalQuestionvalue for Yuzu was changed from 5 to 1, which alters core behavior. Ensure existing unit and integration tests are updated or added to cover this new question count.
totalQuestion: 1,
frontend/src/webview/src/screens/general-feedback-screen/components/FeedbackBox.tsx
Show resolved
Hide resolved
cercil0605
reviewed
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
目的
見やすくするため
やったこと
タイトル参照
動作確認
けいすけに直接見せる