Merged
Conversation
…pen-untitled 拡張機能を起動したときにタイトル未定のファイルが開かれないようにする
…adme フロントのREADMEと拡張のREADMEを分けた
…ll-review-markdown 総評をMarkdownとしてレンダリング
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the frontend for a production deployment by switching feedback rendering to Markdown, reorganizing imports, tweaking the webview opening logic, and updating documentation.
- Render feedback using ReactMarkdown instead of plain typography
- Adjust the VSCode command when no editor is open
- Reorder imports and add the
react-markdowndependency - Revise README to clarify features and add a dev guide
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/screens/general-feedback-screen/components/FeedbackBox.tsx | Replaced <Typography> with <ReactMarkdown> for feedback rendering |
| src/data/create-characters.ts | Alphabetically reordered MUI color imports |
| src/commands/functions/open-webview.ts | Changed fallback command to workbench.action.openWalkthrough |
| src/commands/extension.ts | Reordered imports for consistency |
| frontend/package.json | Added react-markdown dependency |
| frontend/README.md | Enhanced project description, features list, and formatting |
| frontend/README.dev.md | Introduced a development-focused README |
Comments suppressed due to low confidence (3)
frontend/src/webview/src/screens/general-feedback-screen/components/FeedbackBox.tsx:27
- Add a unit or snapshot test for this component to verify that Markdown is rendered correctly and edge cases like empty or large inputs are handled as expected.
<ReactMarkdown>{generalReview}</ReactMarkdown>
frontend/src/commands/functions/open-webview.ts:11
- The
openWalkthroughcommand opens VSCode’s tutorial rather than a blank editor. Confirm this matches the intended UX or revert toworkbench.action.files.newUntitledFileif you want to open an empty document.
"workbench.action.openWalkthrough"
frontend/README.md:1
- [nitpick] The header style differs from the project’s original naming. For clarity and consistency, consider using a single-language title or providing both Japanese and English side by side.
# RepoInterviewer とは？
| }} | ||
| > | ||
| <Typography sx={{ whiteSpace: "pre-wrap" }}>{generalReview}</Typography> | ||
| <ReactMarkdown>{generalReview}</ReactMarkdown> |
There was a problem hiding this comment.
By rendering arbitrary Markdown, untrusted input could include unsafe HTML. Consider enabling ReactMarkdown’s built-in security plugins or stripping HTML nodes to prevent XSS vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.